Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry for transient 'server doesn't have a Resource type errors' after clusterctl move #9065

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

rahulbabu95
Copy link
Member

Issue #, if available:
Sometimes the clusterctl move returns successfully, but the actual resource type isn't available in the management cluster until after sometime. During this edge condition, if we run the kubectl wait command on the management it throws the following error:
executing wait: error: the server doesn't have a resource type \"clusters\"\n",

Description of changes:
If the clusterctl move is successful and we still see this error, treat this as a transient error and add retries to make the cluster creation process more resilient. This should not affect the existing flow as the retries would only kick in if the kubectl wait errors out.

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.38%. Comparing base (a77f775) to head (a951ea5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9065      +/-   ##
==========================================
+ Coverage   72.37%   72.38%   +0.01%     
==========================================
  Files         578      578              
  Lines       45451    45464      +13     
==========================================
+ Hits        32894    32910      +16     
+ Misses      10826    10824       -2     
+ Partials     1731     1730       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eks-distro-bot eks-distro-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 11, 2024
@rahulbabu95 rahulbabu95 force-pushed the poc/kubectl-wait-retry branch from 42b2955 to 99da35e Compare December 11, 2024 20:44
Signed-off-by: Rahul Ganesh <[email protected]>
@rahulbabu95 rahulbabu95 force-pushed the poc/kubectl-wait-retry branch from 04e20e6 to a951ea5 Compare December 11, 2024 23:30
@rahulbabu95
Copy link
Member Author

/hold

@rahulbabu95
Copy link
Member Author

/unhold

@rahulbabu95
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rahulbabu95

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rahulbabu95
Copy link
Member Author

/cherrypick release-0.20

@eks-distro-pr-bot
Copy link
Contributor

@rahulbabu95: once the present PR merges, I will cherry-pick it on top of release-0.20 in a new PR and assign it to you.

In response to this:

/cherrypick release-0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot merged commit 92985cc into aws:main Dec 13, 2024
12 checks passed
@eks-distro-pr-bot
Copy link
Contributor

@rahulbabu95: new pull request created: #9075

In response to this:

/cherrypick release-0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants