-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry for transient 'server doesn't have a Resource type errors' after clusterctl move #9065
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9065 +/- ##
==========================================
+ Coverage 72.37% 72.38% +0.01%
==========================================
Files 578 578
Lines 45451 45464 +13
==========================================
+ Hits 32894 32910 +16
+ Misses 10826 10824 -2
+ Partials 1731 1730 -1 ☔ View full report in Codecov by Sentry. |
42b2955
to
99da35e
Compare
Signed-off-by: Rahul Ganesh <[email protected]>
04e20e6
to
a951ea5
Compare
/hold |
/unhold |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rahulbabu95 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release-0.20 |
@rahulbabu95: once the present PR merges, I will cherry-pick it on top of release-0.20 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rahulbabu95: new pull request created: #9075 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issue #, if available:
Sometimes the
clusterctl move
returns successfully, but the actual resource type isn't available in the management cluster until after sometime. During this edge condition, if we run thekubectl wait
command on the management it throws the following error:executing wait: error: the server doesn't have a resource type \"clusters\"\n",
Description of changes:
If the
clusterctl move
is successful and we still see this error, treat this as a transient error and add retries to make the cluster creation process more resilient. This should not affect the existing flow as the retries would only kick in if the kubectl wait errors out.